Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalized port closing and error warning. #391

Merged
merged 13 commits into from
Jan 30, 2023
Merged

Finalized port closing and error warning. #391

merged 13 commits into from
Jan 30, 2023

Conversation

Alek99
Copy link
Contributor

@Alek99 Alek99 commented Jan 30, 2023 •
edited by picklelo
Loading

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@Alek99 Alek99 closed this Jan 30, 2023
@Alek99 Alek99 reopened this Jan 30, 2023
picklelo
picklelo reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just some comments to clean up the code

pynecone/pc.py Outdated Show resolved Hide resolved
pynecone/pc.py Outdated Show resolved Hide resolved
pynecone/utils.py Show resolved Hide resolved
picklelo
picklelo reviewed Jan 30, 2023
View reviewed changes
pynecone/utils.py
frontend_action = Prompt.ask("Kill it?", choices=["y", "n"])
if frontend_action == "y":
kill_process_on_port(port)
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this else

picklelo
picklelo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

picklelo
picklelo reviewed Jan 30, 2023
View reviewed changes
pynecone/utils.py
Args:
port: The port.
"""
if get_process_on_port(port) is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can store this in a variable so we don't call the function twice

@Alek99 Alek99 merged commit 450576b into main Jan 30, 2023
@picklelo picklelo linked an issue Jan 30, 2023 that may be closed by this pull request
Subprocesses aren't always killed on pc command exit #177
Closed
@Alek99 Alek99 deleted the alek/port branch February 1, 2023 06:27
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
@Alek99 @ACucos1
Finalized port closing and error warning. (reflex-dev#391)
ef28bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subprocesses aren't always killed on pc command exit
2 participants
@Alek99 @picklelo