Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out pclist #407

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Comment out pclist #407

merged 2 commits into from
Jan 31, 2023

Conversation

picklelo
Copy link
Contributor

@picklelo picklelo commented Jan 31, 2023 •
edited
Loading

We have to comment this out for now until it can be pickled to support Redis.

@Alek99 Alek99 self-requested a review January 31, 2023 03:21
@picklelo picklelo mentioned this pull request Jan 31, 2023
Closed
@picklelo picklelo merged commit e578956 into main Jan 31, 2023
@picklelo picklelo deleted the nikhil/comment-pclist branch January 31, 2023 03:25
@TommyDew42
Copy link
Contributor

Thanks for reverting the change for me. We might want to have an unit test for the Redis behaviour here.

ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
@picklelo @ACucos1
Comment out pclist (reflex-dev#407)
de97c00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alek99 Alek99 Alek99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@picklelo @TommyDew42 @Alek99