Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make PCList pickleable #500

Merged
merged 7 commits into from Feb 10, 2023
Merged

make PCList pickleable #500

merged 7 commits into from Feb 10, 2023

Conversation

ElijahAhianyo
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

This pr contains a fix for making the PCList class pickleable using cloudpickle

@ElijahAhianyo
make PCList pickleable
130d4d0 
This pr contains a fix for making the PCList class pickleable using cloudpickle
@ElijahAhianyo ElijahAhianyo marked this pull request as draft February 10, 2023 12:19
@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review February 10, 2023 12:28
picklelo
picklelo approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - tested it out with Redis and it's working nicely now!

@picklelo picklelo merged commit 69a9c95 into reflex-dev:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElijahAhianyo @picklelo