Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color prop to CircularProgress #520

Merged
merged 2 commits into from Feb 12, 2023
Merged

Add color prop to CircularProgress #520

merged 2 commits into from Feb 12, 2023

Conversation

Cheesy-Brik
Copy link
Contributor

@Cheesy-Brik Cheesy-Brik commented Feb 12, 2023

I think the color prop was most likely forgotten, as it's already in Chakra. So just adding this fixes it.

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

Add color prompt from chakra CircularProgress to Pynecone
b. Describe your changes.
Adds a missing color prop that lets you change the color of the progress bar.

I think the color prop was most likely forgotten, as it's already in Chakra. So just adding this fixes it.
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@picklelo picklelo merged commit cdf93ed into reflex-dev:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants