Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix: issue 633] Component List don't support Var(list). #636

Merged
merged 1 commit into from Mar 10, 2023
Merged

[Fix: issue 633] Component List don't support Var(list). #636

merged 1 commit into from Mar 10, 2023

Conversation

d29107d
Copy link
Contributor

@d29107d d29107d commented Mar 6, 2023 •
edited

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

Desc

Component List supports Var(list).
Close #633

@ElijahAhianyo
Copy link
Collaborator

great. I'm realizing there seem to be no unit tests for this component. We could probably use some unit tests in a later PR

@d29107d
Copy link
Contributor Author

d29107d commented Mar 7, 2023

@ElijahAhianyo
Yes, we can add the unit tests in a later PR.

@d29107d
Copy link
Contributor Author

d29107d commented Mar 8, 2023

@picklelo could you help to review this pr?

picklelo
picklelo approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - nice work!

@picklelo picklelo merged commit e926460 into reflex-dev:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component List don't support Var(list).
3 participants
@d29107d @ElijahAhianyo @picklelo