Hot loading asset folder on development #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
reviewed
Mar 7, 2023
pynecone/utils.py
Outdated
| @@ -622,6 +623,10 @@ def run_frontend(app: App, root: Path, port: str): | |||
| # Set up the frontend. | |||
| setup_frontend(root) | |||
|
|
|||
| # start watching asset folder | |||
| asset_watch = AssetFolderWatch(root) | |||
| asset_watch.start() | |||
There was a problem hiding this comment.
Do we need to stop the watch? For example when they ctrl+c, will this still be watching?
There was a problem hiding this comment.
We don't need to do that.
This is a daemon thread so will be killed when the main thread is exited even if it is caused with ctrl+c.
pynecone/watch.py
Outdated
|
|
||
|
|
||
| class AssetFolderHandler(FileSystemEventHandler): | ||
| """Asset folder event handelr.""" |
pynecone/watch.py
Outdated
| self.root = root | ||
|
|
||
| def on_modified(self, event: FileSystemEvent): | ||
| """Event hander when a file or folder was modified. |
pynecone/watch.py
Outdated
| This is called every time after a file is created, modified and deleted. | ||
|
|
||
| Args: | ||
| event: Event infomation. |
pyproject.toml
Outdated
| @@ -49,6 +49,7 @@ toml = "^0.10.2" | |||
| pytest-asyncio = "^0.20.1" | |||
| black = "^22.10.0" | |||
| ruff = "^0.0.244" | |||
| watchdog = "^2.3.1" | |||
There was a problem hiding this comment.
Will we need this in the main dependencies since we need it to be installed in pip install pynecone
|
This also needs to be rebased since we just merged a PR that updated the dependencies. |
Ok, I will. |
PeterYusuke
force-pushed
the
watching-assets
branch
from
4c1a24f
to
ed88f0d
Compare
|
Fix reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Description
Add feature for watching
assetsfolder changes, and do same changes on.web/publicfolder.To work this just execute
pc runwith development, but not production.Close #540.