Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reinforce check for bun install process in "pc init" #938

Merged
merged 2 commits into from
May 4, 2023
Merged

reinforce check for bun install process in "pc init" #938

merged 2 commits into from
May 4, 2023

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented May 4, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

Changes

Refactor the installation process of bun,
clean up the code
and add a reinforced check for the version of bun (using packaging.version)

Closes #901

picklelo
picklelo approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@picklelo picklelo merged commit 4f182b3 into reflex-dev:main May 4, 2023
17 checks passed
@milochen0418
Copy link
Contributor

wow~ nice :DD

@milochen0418 milochen0418 mentioned this pull request May 7, 2023
Closed
@picklelo picklelo mentioned this pull request May 8, 2023
Closed
@milochen0418
Copy link
Contributor

milochen0418 commented May 9, 2023 •
edited

@Lendemor @ElijahAhianyo @picklelo
Hi,
It looks like the bun version checking doesn't work.
The following is my testing result for the new release 0.1.29

My OS is Mac OS X 13.3.1.

Screenshot 2023-05-09 at 10 51 18 AM

Screenshot 2023-05-09 at 10 50 12 AM

Screenshot 2023-05-09 at 10 47 42 AM

@milochen0418 milochen0418 mentioned this pull request May 9, 2023
Closed
@r0b2g1t r0b2g1t mentioned this pull request May 9, 2023
Closed
5 tasks
@ElijahAhianyo
Copy link
Collaborator

Will look into this

@milochen0418 milochen0418 mentioned this pull request May 9, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

@ElijahAhianyo ElijahAhianyo ElijahAhianyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc run failed - because bun's upgrading is not work from installation.
4 participants
@Lendemor @milochen0418 @ElijahAhianyo @picklelo