Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maxBound for threadDelay #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

srid
Copy link

@srid srid commented Jan 16, 2020

No description provided.

@Ericson2314
Copy link
Member

http://hackage.haskell.org/package/fsnotify-0.3.0.1/docs/System-FSNotify.html#v:watchTree It looks like we shouldn't forkIO at all, but instead just be careful to call the action to kill the thread created by watchTree if we ourselves are killed.

@3noch
Copy link
Member

3noch commented Jan 16, 2020

performEventAsync still runs in the same thread; it's up to the Performable m action to forkIO. Although I'm not sure what the implications are if you don't.

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 16, 2020

@3noch I think watchTree doing its own forkIO. performEventAsync is basically performEvent + triggerEvent. It's not a problem if you don't fork IO and even if for some reason watchTree wasn't forkIO-ing (e.g. it was communicating with a preexisting thread) it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants