Skip to content

Commit

Permalink
jobsets.nix: work around GitHub's bad status check semantics
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Trinkle committed May 27, 2018
1 parent 8d0f350 commit a4d6796
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion jobsets.nix
Expand Up @@ -45,7 +45,12 @@ let
description = "#${num}: ${info.title}";
inputs = {
reflex-platform = {
value = "https://github.com/reflex-frp/reflex-platform pull/${num}/merge";
#NOTE: This should really use "pull/${num}/merge"; however, GitHub's
#status checks only operate on PR heads. This creates a race
#condition, which can currently only be solved by requiring PRs to be
#up to date before they're merged. See
#https://github.com/isaacs/github/issues/1002
value = "https://github.com/reflex-frp/reflex-platform pull/${num}/head";
type = "git";
emailresponsible = false;
};
Expand Down

0 comments on commit a4d6796

Please sign in to comment.