Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to delete an User Role from UI #198

Closed
ar3diu opened this issue Jun 20, 2022 · 7 comments
Closed

[BUG] Unable to delete an User Role from UI #198

ar3diu opened this issue Jun 20, 2022 · 7 comments
Assignees
Labels
component: ui The UI component source: community Submitted by the community status: qa Status Quality Assurance type: bug Something isn't working

Comments

@ar3diu
Copy link

ar3diu commented Jun 20, 2022

Describe the bug
Nothing happens when the Delete button is clicked for a Role in the System/Settings/Roles webpage.
I couldn't identify any errors or even logs related to this request.

To Reproduce
Steps to reproduce the behavior:

  1. Go to System/Settings/Roles
  2. Click on the Trash Icon for one of the roles.

Expected behavior
The user should be prompted with a new window to Proceed/Cancel the deletion.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: Brave
    Version 1.33.106 Chromium: 96.0.4664.110
  • Browser: Firefox
    Version: 101.0.1
@ar3diu ar3diu added status: triage Items needing triage type: bug Something isn't working labels Jun 20, 2022
@ar3diu ar3diu changed the title [BUG] Unable to delete a User Role from UI [BUG] Unable to delete an User Role from UI Jun 20, 2022
@n3tsurge
Copy link
Contributor

Will fix in a release this week

@n3tsurge n3tsurge self-assigned this Jun 20, 2022
@n3tsurge
Copy link
Contributor

Functionality exists and works in the API, UI component was never built

@ar3diu
Copy link
Author

ar3diu commented Jun 20, 2022

Thanks for the clarifications, Brian! 🙏

n3tsurge added a commit to reflexsoar/reflex-ui that referenced this issue Jun 20, 2022
@n3tsurge n3tsurge added component: ui The UI component status: qa Status Quality Assurance source: community Submitted by the community and removed status: triage Items needing triage labels Jun 20, 2022
n3tsurge added a commit to reflexsoar/reflex-ui that referenced this issue Jun 20, 2022
…user-role

BUG: Fix for reflexsoar/reflex-api#198 - There was no UI component fo…
@n3tsurge
Copy link
Contributor

Added the UI prompt to confirm intent to delete. Also added UI controls to prevent triggering a delete on system generated Roles (Admin, Analyst) from within the UI. Backend checks to prevent deleting system generated Roles already exist. Roles can also not be deleted if they currently have a user assigned.

This is now in our Dev build so will get tested shortly

@ar3diu
Copy link
Author

ar3diu commented Jun 21, 2022

That's great, Brian!
I hope I'm not too annoying with all these posts.
At the end of the day, I use the Community version that doesn't imply any kind of software support. So feel free to ignore some of my posts sometimes 😆

@n3tsurge
Copy link
Contributor

No these issues are perfect and greatly appreciated! This was designed for community use cuz we want to help the community fill tool gaps. Sorry for all the bugs! Lol

@ar3diu
Copy link
Author

ar3diu commented Jun 21, 2022

I'm glad and thank you for that! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui The UI component source: community Submitted by the community status: qa Status Quality Assurance type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants