Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Organization entry created even though the creation process failed #199

Closed
ar3diu opened this issue Jun 20, 2022 · 5 comments
Closed
Assignees
Labels
component: api The API component component: ui The UI component source: community Submitted by the community status: qa Status Quality Assurance type: bug Something isn't working

Comments

@ar3diu
Copy link

ar3diu commented Jun 20, 2022

Describe the bug
When creating an new organization, you are prompted to create an Admin user for that specific organization. But you are allowed to skip this part:

image

and this will result in an Internal Server Error.

image

Although you still have to choose between Dismiss and Create options, an entry has already been created in System/Settings/Organizations.

image

Any other objects linked to that specific organization from now on, will not work (e.g roles, users, inputs).

To Reproduce
Steps to reproduce the behavior:

  1. Go to System/Settings
  2. Click on Organizations/New Organization
  3. Fill all the details in Define the Organization window. Click Next.
  4. Do not fill any details in the Create Admin User window and just click Next.
  5. Click Create and see the Internal Server Error.
  6. Now Click Dismiss.
  7. Refresh the System/Settings/Organizations page.
  8. Observe the new entry.

Expected behavior
An entry in the Organizations Tab should not be created if the creation process has failed.

Screenshots
See above.

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: Brave
    Version 1.33.106 Chromium: 96.0.4664.110
  • Browser: Firefox
    Version: 101.0.1
@ar3diu ar3diu added status: triage Items needing triage type: bug Something isn't working labels Jun 20, 2022
@ar3diu ar3diu changed the title [BUG] Organization created even though the creation process failed [BUG] Organization entry created even though the creation process failed Jun 20, 2022
@n3tsurge
Copy link
Contributor

Will fix, I am going to create a release for this week that has this and others

@n3tsurge n3tsurge self-assigned this Jun 20, 2022
n3tsurge added a commit that referenced this issue Jun 20, 2022
…admin user which caused all sorts of chaos, enabled API validation
@n3tsurge n3tsurge added component: api The API component component: ui The UI component status: in progress An item that is currently being worked. source: community Submitted by the community and removed status: triage Items needing triage labels Jun 20, 2022
n3tsurge added a commit that referenced this issue Jun 20, 2022
…n-user-199

BUG: Fixes #199 - Organizations could be created…
@n3tsurge n3tsurge added status: qa Status Quality Assurance and removed status: in progress An item that is currently being worked. labels Jun 20, 2022
@n3tsurge
Copy link
Contributor

Enabled API validation on the Create Organizations endpoint requiring the default admin information

This is now in the dev build and will be validated shortly

@ar3diu
Copy link
Author

ar3diu commented Jun 21, 2022

Thank you for considering this so quickly!
Is there any emailing list for announcing new versions available or will it just be posted on Twitter? 🤔

@n3tsurge
Copy link
Contributor

We do plan to have a mailing list @SMAPPER manages that but you can sign up for updates at the bottom of the website here https://reflexsoar.com/

Also all new releases will be notified on Twitter and a Discussion Topic here on GitHub and we plan to have a Blog section on https://reflexsoar.com/ at some point highlighting whats new

@ar3diu
Copy link
Author

ar3diu commented Jun 21, 2022

Got this error while trying to subscribe:

Message could not be sent.Mailer Error: SMTP connect() failed. https://github.com/PHPMailer/PHPMailer/wiki/Troubleshooting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: api The API component component: ui The UI component source: community Submitted by the community status: qa Status Quality Assurance type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants