add InsecureSkipServerNameVerify to tls.Config #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaukas
requested changes
Feb 4, 2023
handshake_client.go
Outdated
|
|
||
| // [UTLS SECTION START] | ||
| skipServerNameVerify := config.InsecureSkipVerify || config.InsecureSkipServerNameVerify | ||
| if len(config.ServerName) == 0 && !skipServerNameVerify { | ||
| return nil, nil, errors.New("tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config") |
There was a problem hiding this comment.
Could you please also update the error message to reflect your changes made to Config
u_conn.go
Outdated
| @@ -377,7 +377,8 @@ func (c *UConn) clientHandshake(ctx context.Context) (err error) { | |||
| // [uTLS section begins] | |||
| // don't make new ClientHello, use hs.hello | |||
| // preserve the checks from beginning and end of makeClientHello() | |||
| if len(c.config.ServerName) == 0 && !c.config.InsecureSkipVerify { | |||
| skipServerNameVerify := c.config.InsecureSkipVerify || c.config.InsecureSkipServerNameVerify | |||
| if len(c.config.ServerName) == 0 && !skipServerNameVerify { | |||
| return errors.New("tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config") | |||
|
Also |
gaukas
approved these changes
Feb 4, 2023
|
Thanks! I will now get this merged. |
|
Nice work! But it would be better that if we can indicate another ServerName to verify, see #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.