Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #127 #175

Merged
merged 3 commits into from
Mar 20, 2023
Merged

fixes #127 #175

merged 3 commits into from
Mar 20, 2023

Conversation

fqrious
Copy link
Contributor

@fqrious fqrious commented Mar 15, 2023

No description provided.

gaukas
gaukas reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@gaukas gaukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit. I suggested a few changes maybe you want to check out.

handshake_client_tls13.go Outdated Show resolved Hide resolved
handshake_client_tls13.go Show resolved Hide resolved
handshake_client_tls13.go Show resolved Hide resolved
handshake_client.go Outdated Show resolved Hide resolved
@fqrious @gaukas
Update handshake_client_tls13.go
e1cc6b1 
Co-authored-by: Gaukas Wang <i@gauk.as>
@fqrious
Copy link
Contributor Author

fqrious commented Mar 20, 2023

I think I've resolved all suggestions

@gaukas gaukas merged commit 6d2506f into refraction-networking:master Mar 20, 2023
@fqrious fqrious deleted the keyshareFix branch March 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaukas gaukas gaukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fqrious @gaukas