fix: (*UConn).Read() and Secure Renegotiation
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy `(*Conn).Read` to `(*UConn).Read` and force it use `(*UConn).Handshake`. Same for `handleRenegotiation` and `handlePostHandshakeMessage`. Signed-off-by: Gaukas Wang <i@gaukas.wang>
This make sure the renegotiation would work in certain scenarios instead of no scenarios. Signed-off-by: Gaukas Wang <i@gaukas.wang>
gaukas
changed the title
(*Conn).Handshake() and Secure Renegotiation(*UConn).Read() and Secure Renegotiation
gaukas
added a commit
that referenced
this pull request
Apr 10, 2024
* fix: UConn Read does not trigger correct Handshake Copy `(*Conn).Read` to `(*UConn).Read` and force it use `(*UConn).Handshake`. Same for `handleRenegotiation` and `handlePostHandshakeMessage`. Signed-off-by: Gaukas Wang <i@gaukas.wang> * update: use VerifyData in RenegotiationInfoExt This make sure the renegotiation would work in certain scenarios instead of no scenarios. Signed-off-by: Gaukas Wang <i@gaukas.wang> --------- Signed-off-by: Gaukas Wang <i@gaukas.wang>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #291:
(*UConn).Read()incorrectly calling(*Conn).Handshake()Close #284: Secure Renegotiation fails due to #291 and RenegotiationExt was Fake.