Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test: optimize tests and add more CI test target coverage #31

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented Jan 15, 2024

As mentioned in #22, in this PR we introduce tests on target architectures other than AMD64, and re-enable windows/amd64 with gaukas/wazero v1.6.1-w being released with wazero v1.7.0 designated fix for windows (#24).

In addition, this PR also covers #29 by properly simplify examples/tests for Dialer, Listener, and Relay.

Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* Bump up dependency on gaukas/wazero to v1.6.1-w, a special early bird version of v1.7.0 to fix a bug preventing tests to run properly on Windows. (#24)

* Add automated CI test for linux on arm64(aarch64) and riscv64. (#22)

* Re-enable automated CI test for windows on amd64(x86_64). (#24)

* Add automated CI test for macos/arm64 (on M1) by FlyCI.net (untested). (#22)

* Update README.md to reflect the latest status of platform test coverage.

* Disable runnable test of ExampleDialer. (#29)

Signed-off-by: Gaukas Wang <i@gaukas.wang>
* Remove the unnecessary use of goroutines in tests (and examples-are-tests). (#29)

* Localize all TCP listeners listening address to dismiss a firewall pop-up on Windows during testing. (#22, #24)

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Disable CGO, and combine flyCI.yml into the main workflow.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
So test on Windows would pass.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas merged commit 1aa64b6 into master Jan 16, 2024
1 check passed
@gaukas gaukas deleted the gaukas/optimized-test branch January 17, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants