Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃嵀 example: more generalized examples #33

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented Jan 17, 2024

In this PR we combined a few contributions:

  • Make examples more generalized. Now dialer, listener, and relay take an input wasm file to run.
  • Fix an issue causing contexts not being properly propagated into the underlying WebAssembly runtime. Deprecate most of context-less functions (i.e., Instead of NewCore, recommend using NewCoreWithContext.)
  • Make intentional sleeps in some test shorter to speed up testing. Also, reduce the hardcoded test iteration.

Note that we are not bumping up the dependency, gaukas/wazero to v1.6.2-w yet. More comprehensive testing to be done on it to better understand its performance implication.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas self-assigned this Jan 17, 2024
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaukas gaukas merged commit 7fe213c into master Jan 17, 2024
15 checks passed
@gaukas gaukas deleted the gaukas/generalize-examples branch January 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants