Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wazero runtime/module config direct access #44

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented Feb 1, 2024

These direct access should be replaced with corresponding functions, such that some default behavior added by us will be executed correctly with or without user intervention.

These direct access should be replaced with corresponding functions.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas self-assigned this Feb 1, 2024
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaukas gaukas merged commit 5ee6e9d into master Feb 1, 2024
15 checks passed
@gaukas gaukas deleted the gaukas/fix-wazero-config-logic branch February 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants