Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挜 breaking: fix, cleanup, and rename non-API function #47

Merged
merged 8 commits into from
Feb 10, 2024
Merged

馃挜 breaking: fix, cleanup, and rename non-API function #47

merged 8 commits into from
Feb 10, 2024

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented Feb 10, 2024 •
edited

  • Fix a bug causing unit tests to fail when using Go-based WATM.
  • Rename a function and add more detailed instruction on how to/not to use it.
  • Bump up GitHub Action Go version to Go 1.22. Deprecate Go 1.20 (still supported as minimal version).
  • Add CODEOWNERS for auto PR review request.
  • More documentations.

We plan to release v0.5.0 after this has merged.

@gaukas
docs: cleanup docs and fix bad function naming
cab7506 
This introduces a few breaking changes by renaming some of the exported functions. Affected functions are not considered a part of WATER API.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
new: add CODEOWNERS
9574b67 
Add CODEOWNERS to automatically request code review on new pull requests.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
update: bump go version used by GitHub Actions
610ba56 
Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
example: formalize WATM examples
bbd37ed 
Use optimized Rust/Go-based WATM.
Replacing WATMs under testdata with TinyGo-based ones.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
fix: ECANCELED returned by worker considered error
d1f7190 
Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas marked this pull request as ready for review February 10, 2024 05:23
@gaukas gaukas self-assigned this Feb 10, 2024
@gaukas gaukas linked an issue Feb 10, 2024 that may be closed by this pull request
docs: add clarification of RegisterXxx functions and how to enable specific versions of transport module support #38
Closed
@gaukas
馃挜 breaking: UnimplementedConn is not Conn
5449df3 
UnimplementedConn does not need to implement `net.Conn`, since it is the most basic type instead of an extension introduced by WATER.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
馃挜 breaking: UnimplementedListener
0405766 
UnimplementedListener does not need to implement `net.Listener` since it is a basic type. The goal is to cover the extension added by WATER, so it should only implement non-standard library interfaces.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas
lint: mustEmbedUnimplemented nolint unused
8cfb4e3 
Signed-off-by: Gaukas Wang <i@gaukas.wang>
erikziyunchi
erikziyunchi approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the enhancement!

@gaukas gaukas merged commit 9da889f into master Feb 10, 2024
15 checks passed
@gaukas gaukas deleted the gaukas/cleanup-and-fix-doc branch February 10, 2024 22:06
@gaukas gaukas added this to the v0.5.0 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikziyunchi erikziyunchi erikziyunchi approved these changes

Assignees

@gaukas gaukas

Labels
None yet
Projects
None yet
Milestone
v0.5.0
2 participants
@gaukas @erikziyunchi