Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: WATM v1 driver #65

Merged
merged 8 commits into from
Apr 8, 2024
Merged

v1: WATM v1 driver #65

merged 8 commits into from
Apr 8, 2024

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented Apr 1, 2024

This PR adds the draft driver for WebAssembly Transport Module version 1, which is expected to be the first stable version for WATER's WATM standards.

- SetDefaultLogger is now deprecated
- SetDefaultLogHandler is now deprecated

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
- Add DialManaged as a new interface which works like a dialer without remote address as input.
- Naming is tentative.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Starting v1 we seek to use memory-based file system instead of tmpfs for watm config.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
A new util for validating WATM-provided dialing destination address.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Add additional cancellable wrapper around the input context to allow core-level cancellation.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
v1: rename, reformat, and regulate/standardize the function import/exports.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas marked this pull request as ready for review April 5, 2024 20:40
@gaukas gaukas requested a review from ewust April 5, 2024 20:40
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding v1! Maybe we can add some special / edge tests later.

@gaukas gaukas merged commit f420809 into master Apr 8, 2024
15 checks passed
@gaukas gaukas deleted the watm-driver-v1 branch June 12, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants