Skip to content

Commit

Permalink
Merge pull request #690 from ajocksch/benchmarks/mch_description
Browse files Browse the repository at this point in the history
[test] Add description to the collective halo tests
  • Loading branch information
vkarak committed Mar 13, 2019
2 parents 3946e28 + 2f4d11f commit d2b34e3
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions cscs-checks/mch/collectives_halo.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import reframe.utility.sanity as sn


class CollectivesBaseTest(rfm.RegressionTest):
class CommunicationTestBase(rfm.RegressionTest):
def __init__(self, variant, bench_reference):
super().__init__()
self.valid_systems = ['dom:gpu', 'daint:gpu', 'kesch:cn']
Expand Down Expand Up @@ -86,8 +86,11 @@ def setup(self, *args, **kwargs):
'--cpu_bind=q']


# the values default, nocomm and nocomp refer to the different parts
# of the check where the time is measured; default == all
# nocomm == no communication nocomp == no computation
@rfm.parameterized_test(['default'], ['nocomm'], ['nocomp'])
class AlltoallvTest(CollectivesBaseTest):
class AlltoallvTest(CommunicationTestBase):
def __init__(self, variant):
super().__init__(variant,
{
Expand All @@ -102,13 +105,14 @@ def __init__(self, variant):
'default': 0.0138493
}
})
self.descr = 'Alltoall communication test'
self.strict_check = False
self.sourcesdir = 'https://github.com/cosunae/comm_overlap_bench'
self.prebuild_cmd = ['git checkout alltoallv']


@rfm.parameterized_test(['default'], ['nocomm'], ['nocomp'])
class HaloExchangeTest(CollectivesBaseTest):
class HaloExchangeTest(CommunicationTestBase):
def __init__(self, variant):
super().__init__(variant,
{
Expand All @@ -123,5 +127,6 @@ def __init__(self, variant):
'default': 2.53509
}
})
self.descr = 'Halo-cell exchange test'
self.sourcesdir = 'https://github.com/MeteoSwiss-APN/comm_overlap_bench.git'
self.prebuild_cmd = ['git checkout barebones']

0 comments on commit d2b34e3

Please sign in to comment.