Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix remote topology detection for pip installations #2978

Merged
merged 3 commits into from Sep 11, 2023

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Aug 31, 2023

What we do essentially is to fall back in a venv+pip install solution if we can't copy the standard source structure. In that case, we install reframe from pip in a venv and invoke reframe --detect-host-topology.

Also this PR removes the parallel launcher from the remote detection script as suggested in #2926.

Closes #2914.

FYI: @casparvl @jack-morrison.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (dfa93c3) 87.35% compared to head (c8983c5) 87.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
- Coverage   87.35%   87.29%   -0.06%     
==========================================
  Files          60       60              
  Lines       11684    11692       +8     
==========================================
  Hits        10207    10207              
- Misses       1477     1485       +8     
Files Changed Coverage Δ
reframe/frontend/autodetect.py 57.32% <0.00%> (-3.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reframe/frontend/autodetect.py Outdated Show resolved Hide resolved
reframe/frontend/autodetect.py Outdated Show resolved Hide resolved
@vkarak vkarak merged commit fd77789 into reframe-hpc:master Sep 11, 2023
17 of 19 checks passed
@vkarak vkarak deleted the bugfix/remote-autodetect-pip branch September 11, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remote partition processor auto-detection fails when ReFrame is installed from PyPI
2 participants