Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testlib] Added QuantumESPRESSO scalability test for pw.x #3134

Merged
merged 11 commits into from
Mar 20, 2024

Conversation

Crivella
Copy link
Contributor

@Crivella Crivella commented Mar 1, 2024

This PR adds a reframe reusable test for QuantumESPRESSO, aimed at testing the scaling pw.x executable.

The parameters ecut and nbnd can be tuned in order to increase the usage of either FFTW or diagonalization routines.

For now the input file is baked into the source code, but it could be easily moved to a separate repo, like for the GROMACS test

@pep8speaks
Copy link

pep8speaks commented Mar 1, 2024

Hello @Crivella, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-03-13 10:34:31 UTC

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@victorusu
Copy link
Contributor

@Crivella, the only thing I think it misses is the documentation associated to the hpctestlib. If you don't have time to write let me know.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (f2419e8) to head (091d253).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3134   +/-   ##
========================================
  Coverage    86.66%   86.66%           
========================================
  Files           61       61           
  Lines        12092    12092           
========================================
  Hits         10480    10480           
  Misses        1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Crivella
Copy link
Contributor Author

Crivella commented Mar 5, 2024

@victorusu Let me know if what I've added with the last 2 commits is enough. I see there is a test failing but it does not seem to be related to my changes?

@vkarak
Copy link
Contributor

vkarak commented Mar 8, 2024

@Crivella Could you also fix the styling issues listed here?

Hello @Crivella, Thank you for updating!

Line 56:1: W293 blank line contains whitespace
Line 59:77: W291 trailing whitespace
Line 62:66: W291 trailing whitespace
Line 69:80: E501 line too long (100 > 79 characters)
Line 87:50: W291 trailing whitespace

Do see the ReFrame Coding Style Guide

Comment last updated at 2024-03-05 09:25:49 UTC

@Crivella
Copy link
Contributor Author

Crivella commented Mar 9, 2024

@vkarak Done! Sorry didn't realize the bot updated it's old message

@vkarak vkarak changed the title Added QuantumESPRESSO scalability test for pw.x [testlib] Added QuantumESPRESSO scalability test for pw.x Mar 19, 2024
@victorusu victorusu merged commit 7e6514a into reframe-hpc:develop Mar 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants