Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add a perflog entry also when sanity fails #3189

Merged
merged 4 commits into from
May 15, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented May 13, 2024

The idea is the same as exposed in the issue.
In case of sanity failures, we execute also the performance stage but in dry-run mode suppressing any non-aborting exception. To achieve so, we also extended the dry-run mode inside the performance stage to also generate the perfvalues which are required by the logging handlers for emitting the performance record.

In case of sanity failures, the performance values will be logged as None.

Todos

  • Add a check_fail_reason log format placeholder for allowing the fail reason to be also logged.

Closes #3186.

@vkarak vkarak self-assigned this May 13, 2024
@pep8speaks
Copy link

pep8speaks commented May 13, 2024

Hello @vkarak, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-05-15 10:45:12 UTC

reframe/core/pipeline.py Outdated Show resolved Hide resolved
@vkarak vkarak force-pushed the feat/always-log-perftests branch from 662c93e to 28aa6c3 Compare May 13, 2024 17:48
unittests/test_policies.py Outdated Show resolved Hide resolved
@teojgo teojgo self-requested a review May 15, 2024 14:06
@vkarak vkarak merged commit 39e6272 into reframe-hpc:develop May 15, 2024
23 checks passed
@vkarak vkarak deleted the feat/always-log-perftests branch May 15, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

If a performance test fails in sanity or earlier no perflog entry is created
3 participants