Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Display Python imports in the first tutorial example #3195

Merged
merged 2 commits into from
May 17, 2024

Conversation

createyourpersonalaccount
Copy link
Contributor

The tutorial was skipping the two imports

import reframe as rfm
import reframe.utility.sanity as sn

by using the :pyobject: option to only highlight stream_test. This is the first example shown in the tutorial and it is important that the entire file is displayed.

Presumably this technique is used to avoid the license notice; we can use :start-at: instead.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also rebase your PR over master (including your commit)?

docs/tutorial.rst Outdated Show resolved Hide resolved
@createyourpersonalaccount createyourpersonalaccount force-pushed the fixing-tutorial branch 2 times, most recently from 59ef58e to 3805a92 Compare May 15, 2024 22:12
@createyourpersonalaccount createyourpersonalaccount changed the base branch from develop to master May 15, 2024 22:15
The tutorial was skipping the two imports

    import reframe as rfm
    import reframe.utility.sanity as sn

by using the :pyobject: option to only highlight stream_test. This is
the first example shown in the tutorial and it is important that the
entire file is displayed.

Presumably this technique is used to avoid the license notice; we can
use :lines: instead.
@vkarak vkarak changed the title display python imports in first example in tutorial [doc] Display Python imports in the first tutorial example May 15, 2024
@vkarak vkarak merged commit b1524a2 into reframe-hpc:master May 17, 2024
22 checks passed
@createyourpersonalaccount createyourpersonalaccount deleted the fixing-tutorial branch May 18, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants