Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix broken cross links in the documentation #3196

Merged

Conversation

createyourpersonalaccount
Copy link
Contributor

The link was broken and it is now fixed.

Let me know if you are interested in fixing the links in ReFrame's documentation; I can take up the task.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also rebase the PR and the commit on master?

docs/tutorial.rst Outdated Show resolved Hide resolved
@createyourpersonalaccount createyourpersonalaccount changed the base branch from develop to master May 15, 2024 22:23
docs/pipeline.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Show resolved Hide resolved
@vkarak vkarak changed the title fixing cross links in tutorial [doc] Fix broken cross links in the documentation May 16, 2024
@createyourpersonalaccount
Copy link
Contributor Author

@vkarak done, you can merge

@vkarak
Copy link
Contributor

vkarak commented May 18, 2024

I have pushed some improvement and style fixes to your branch, which are lost with your forced push. I will revert the links myself and force push.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now. Thanks!

@vkarak vkarak merged commit 0bee29c into reframe-hpc:master May 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants