Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support same named page config files, e.g. pages/index.page.js & foo/index.page.js. #3

Closed
brillout opened this issue Sep 11, 2019 · 3 comments

Comments

@brillout
Copy link
Owner

As pointed by @chriscalo in #2.

@chriscalo
Copy link

Copying what I said in #2 here to save some back-and-forth:

I like structuring files in web apps in a way that matches URL paths. However, goldpage yells at me when more than one page config file has the same name. Here's how I prefer to structure things, but this doesn't work with goldpage because there are two index.page.js files (even though they're in different folders):

/ => pages/index.page.js
/foo => pages/foo/index.page.js

@brillout brillout changed the title Support same named page config files, e.g. index.html. Support same named page config files, e.g. pages/index.page.js & foo/index.page.js. Sep 14, 2019
@brillout
Copy link
Owner Author

brillout commented Sep 14, 2019

Done & published as 0.5.2.

@chriscalo
Copy link

Seems to work great, thanks so much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants