Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open editable files on the left, non editable on the right #137

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Jun 12, 2023

Fixes #131 and fixes #128

With this PR PDF files are opened in the right panel, while the others open on the left. Note that the split file feature is still available as an action from the open files tree.

This PR also adds unit tests for the atom fileActions (and indirectly to the related core atoms). I've added also an action atom to close all files closeAllFilesAtom.

image

@cguedes cguedes linked an issue Jun 12, 2023 that may be closed by this pull request
@cguedes cguedes marked this pull request as ready for review June 12, 2023 09:53
@hammer
Copy link
Contributor

hammer commented Jun 12, 2023

Thanks I think this reduction in feature complexity is a good one!

A thought while trying out the PR: I wonder if there's an easy way to add a way to close all reading tabs, similar to clicking on the icons on the left to collapse the left sidebar? I guess we're starting to get too many kinds of UI elements with a left sidebar, a second reading pane, and a right sidebar, and it would be good to unify or standardize them. No action to take now, just thinking out loud.

@cguedes
Copy link
Collaborator Author

cguedes commented Jun 12, 2023

A thought while trying out the PR: I wonder if there's an easy way to add a way to close all reading tabs, similar to clicking on the icons on the left to collapse the left sidebar? I guess we're starting to get too many kinds of UI elements with a left sidebar, a second reading pane, and a right sidebar, and it would be good to unify or standardize them. No action to take now, just thinking out loud.

We can have an action in the "OPEN FILES" panel header like vs code.

image

This is very easy to implement as we already have the operation closeAllFilesAtom. Should I create a task for this?

@cguedes cguedes requested a review from sehyod June 12, 2023 13:57
src/atoms/fileActions.ts Outdated Show resolved Hide resolved
src/atoms/fileActions.test.ts Outdated Show resolved Hide resolved
src/atoms/fileActions.test.ts Outdated Show resolved Hide resolved
src/atoms/fileActions.test.ts Show resolved Hide resolved
src/atoms/fileActions.test.ts Outdated Show resolved Hide resolved
src/atoms/fileActions.test.ts Outdated Show resolved Hide resolved
src/atoms/fileActions.test.ts Outdated Show resolved Hide resolved
@hammer
Copy link
Contributor

hammer commented Jun 12, 2023

Should I create a task for this?

Sure!

@sergioramos sergioramos changed the title feat: 131 open editable files in the left and non editable ex pdfs in the right feat: open editable files on the left, non editable on the right Jun 13, 2023
@sergioramos sergioramos merged commit d58bdee into main Jun 13, 2023
9 checks passed
@sergioramos sergioramos deleted the 131-open-editable-files-in-the-left-and-non-editable-ex-pdfs-in-the-right branch June 13, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open editable files in the left and non-editable (ex PDFs) in the right Add tests for files atoms
4 participants