-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new endpoint for ingestion status #181
Merged
cguedes
merged 19 commits into
main
from
113-ability-to-display-reference-ingestion-status-new-endpoint
Jun 23, 2023
Merged
feat: Add new endpoint for ingestion status #181
cguedes
merged 19 commits into
main
from
113-ability-to-display-reference-ingestion-status-new-endpoint
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 66.53% 66.91% +0.37%
==========================================
Files 87 87
Lines 4429 4498 +69
Branches 331 331
==========================================
+ Hits 2947 3010 +63
- Misses 1465 1471 +6
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gjreda
commented
Jun 22, 2023
gjreda
commented
Jun 22, 2023
gjreda
commented
Jun 22, 2023
gjreda
changed the title
Add new endpoint for ingestion status
feat: Add new endpoint for ingestion status
Jun 22, 2023
cguedes
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update README
- Create a new command to be able to set the correct return type (CliCommands are per command)
- Try to make status field mandatory
cguedes
approved these changes
Jun 23, 2023
cguedes
deleted the
113-ability-to-display-reference-ingestion-status-new-endpoint
branch
June 23, 2023 16:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #113
Example response below. If an unhandled exception is raised when calling this endpoint, we'll return
"status": "error"
with an empty list of statuses.