-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix regression issue with drag-drop in editor #192
Conversation
…ML events Also, adds tauri menu entry
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 66.91% 70.36% +3.44%
==========================================
Files 87 91 +4
Lines 4498 4592 +94
Branches 331 370 +39
==========================================
+ Hits 3010 3231 +221
+ Misses 1471 1344 -127
Partials 17 17
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I let two comments, but nothing blocking.
While testing locally, I realised that you can still drag and drop a file on the title bar and it opens it with no way of getting out. It's very specific, I don't think it has to be fixed in this PR, but we should create a ticket for it to fix it later on.
The upload files feature broke the drag-drop of draggable elements in the TipTap editor!
References -> Upload...
to open the upload files dialogrefstudio-pr-192.mov
NOTE: This PR don't aim to improve the left references sidebar.
This will close #173