Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use setUpEditorWithSelection in all tests #220

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Jun 29, 2023

We had to skip a failing test in a previous PR (#215). Debugging the issue was difficult because the test was not using the util function setUpEditorWithSelection.

This PR adds the function to all the existing tests, to make the tests more legible

@sehyod sehyod requested a review from cguedes June 29, 2023 10:28
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #220 (256a2f0) into main (b70068c) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   72.18%   72.31%   +0.13%     
==========================================
  Files         103      103              
  Lines        5069     5064       -5     
  Branches      405      407       +2     
==========================================
+ Hits         3659     3662       +3     
+ Misses       1392     1384       -8     
  Partials       18       18              
Impacted Files Coverage Δ
...textEditor/components/tipTapNodes/test-fixtures.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod changed the title chore: Rename file to editor chore: use setUpEditorWithSelection in all tests Jun 29, 2023
@cguedes cguedes merged commit a15b30f into main Jun 29, 2023
11 checks passed
@cguedes cguedes deleted the use-util-function-to-setup-editor-for-tests branch June 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants