Feature splashscreen #309
Merged
Feature splashscreen #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enders Note that the webkit white background is a pending tauri issue: tauri-apps/tauri#1564
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 86.33% 86.47% +0.14%
==========================================
Files 135 137 +2
Lines 7528 7577 +49
Branches 823 833 +10
==========================================
+ Hits 6499 6552 +53
+ Misses 1016 1011 -5
- Partials 13 14 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
reviewed
Jul 18, 2023
sehyod
previously approved these changes
Jul 18, 2023
|
We can get rid of the white background by using a transparent splashscreen window with the
Note: Using the Check the implementation here. |
This reverts commit 0b267ce.
sehyod
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #308 by delaying app execution with a Tauri splash screen.
The splash screen is shown by default (main window is hidden by default) and then, when, the app is ready the command
close_splashscreen) is executed and will hide splash screen and show the main window.Note that the main window code still runs, while the app is not visible, so we have updated the root component to ensure the
<App>...</App>component is only rendered when the app is ready.Also, there is an initial white background in the splashscreen. Before rendering the content. There is a pending issue reported to track that.
Screen.Recording.2023-07-18.at.12.05.20.mov