fix: make indent commands return proper command result #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
indent
andunindent
commands were returningtrue
to block default behavior ofTab
andShift-Tab
shortcuts. However this made theBackspace
command believe that the content could be unindented, blocking the fallback behavior of the shortcut, which is merging the line with the previous one.Solution
This changes the return result of
indent
andunindent
commands back to the proper boolean indicating whether the command can run.Tab
andShift-Tab
shortcuts are now the one responsible for returningtrue
to block the default behavior of these shortcuts.Fixes #342