Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide div selection from editor #344

Merged
merged 29 commits into from
Aug 16, 2023
Merged

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Aug 14, 2023

Fixes #327
This removes the default selection color and uses a background on text only, like notion does.

Screen.Recording.2023-08-14.at.12.37.59.mov

@sehyod sehyod marked this pull request as draft August 14, 2023 11:39
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #344 (b081d25) into main (5bc3dea) will increase coverage by 2.02%.
The diff coverage is 100.00%.

❗ Current head b081d25 differs from pull request most recent head 517a86c. Consider uploading reports for the commit 517a86c to get more accurate results

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   84.37%   86.39%   +2.02%     
==========================================
  Files         157      150       -7     
  Lines        9344     8519     -825     
  Branches     1014      965      -49     
==========================================
- Hits         7884     7360     -524     
+ Misses       1449     1148     -301     
  Partials       11       11              
Files Changed Coverage Δ
...tipTapNodes/refStudioDocument/RefStudioDocument.ts 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod marked this pull request as ready for review August 16, 2023 10:07
@cguedes cguedes merged commit c1bebd9 into main Aug 16, 2023
9 checks passed
@cguedes cguedes deleted the hide-div-selection-from-editor branch August 16, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When you select text, there are broken rectangles for lines that aren't completely selected
2 participants