-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Project Lifecycle #350
Merged
cguedes
merged 27 commits into
main
from
288-allow-for-projects-to-be-created-saved-opened-and-deleted
Aug 16, 2023
Merged
feat: Project Lifecycle #350
cguedes
merged 27 commits into
main
from
288-allow-for-projects-to-be-created-saved-opened-and-deleted
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pened-and-deleted
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 86.35% 84.94% -1.42%
==========================================
Files 150 153 +3
Lines 8487 8819 +332
Branches 957 973 +16
==========================================
+ Hits 7329 7491 +162
- Misses 1147 1317 +170
Partials 11 11
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
reviewed
Aug 15, 2023
sehyod
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286, #288
This PR adds four new operations to Ref Studio to control the project lifecycle.
Operations
New Project
When a new project is created (default directory is the users desktop folder), a modal asks for the project name, and the project is created empty (no files, no uploads folder) and with a unsaved file open.
Notes
Open Project
When a project is requested to be open, a folder explorer modal is opened (opens desktop by default). After selection, the current open project is closed and the new one is open.
Notes:
Close project
Closing a project can be done via
File -> Close Project
or via the explorer panel icon (X).When a project is closed, all the open editors are closed and the project path reset to an empty string "".
Try Sample Project
Trying a sample project will create a sample folder
RefStudio Sample
in the Desktop folder with 3 files (the ones we've had before).Notes:
Extra Notes
settings.general
keys and created new key for the current open projectproject.currentDir
.settings.general.appDataDir + settings.appDataDir.projectName
to the newproject.currentDir
on the first run./Users/USER/Library/Application Support/studio.ref.desktop/refstudio-settings.json
).uploads
folder creation is delayed to the first upload (so that new projects won't have that empty folder listed).