-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web call sidecar http #382
Conversation
Note: I've had to change this bc I was getting an error like: ``` response = sidecar.ingest.get_statuses() ^^^^^^^^^^^^^^ AttributeError: module 'sidecar' has no attribute 'ingest' ```
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 84.25% 84.10% -0.16%
==========================================
Files 174 174
Lines 9946 9964 +18
Branches 1097 1097
==========================================
Hits 8380 8380
- Misses 1555 1573 +18
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Update HTTP api interface - Update format save rules for python
@@ -13,6 +13,11 @@ | |||
"[typescript]": { | |||
"editor.formatOnSave": true | |||
}, | |||
"[python]": { | |||
"editor.formatOnSave": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjreda added this configurations to prevent VSCode from automatically format the python code with prettier.
Let me know what is the code formatter we should use and I can configure it instead of "ms-python.python".
This PR fixes #380 that allows the web application to call the sidecar commands via HTTP interface.
Also adds utility startup scripts and updates README.md