Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sidebar design #383

Merged
merged 20 commits into from
Aug 22, 2023
Merged

feat: update sidebar design #383

merged 20 commits into from
Aug 22, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Aug 18, 2023

This adds a generic Sidebar component, uses it for the left sidebar, and replaces the right panel logic with a second sidebar on the right
This also fixes the background of the splashscreen to be the same as the one of the welcome screen, instead of white

Screenshot 2023-08-22 at 14 43 06

NB: This PR does not update the sidebar panels (like the references panel, the file explorer panel, etc.)

Closes #371

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #383 (20b4ea5) into main (a1c7f9e) will decrease coverage by 1.08%.
Report is 1 commits behind head on main.
The diff coverage is 36.65%.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   84.16%   83.09%   -1.08%     
==========================================
  Files         175      161      -14     
  Lines       10016     9192     -824     
  Branches     1101     1106       +5     
==========================================
- Hits         8430     7638     -792     
+ Misses       1575     1540      -35     
- Partials       11       14       +3     
Files Changed Coverage Δ
src/application/App.tsx 0.00% <0.00%> (ø)
src/application/sidebar/LeftSidePanelWrapper.tsx 0.00% <0.00%> (ø)
src/application/sidebar/RightSidePanelWrapper.tsx 0.00% <0.00%> (ø)
src/application/sidebar/icons.tsx 0.00% <0.00%> (ø)
src/components/VerticalResizeHandle.tsx 0.00% <0.00%> (ø)
src/splash.tsx 0.00% <0.00%> (ø)
src/application/components/SideBar.tsx 100.00% <100.00%> (ø)
src/features/ai/sidebar/ChatPanel.tsx 100.00% <100.00%> (ø)
src/features/ai/sidebar/RewriterPanel.tsx 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod marked this pull request as ready for review August 21, 2023 16:26
@sehyod sehyod requested a review from cguedes August 22, 2023 13:48
src/application/App.tsx Outdated Show resolved Hide resolved
src/application/App.tsx Outdated Show resolved Hide resolved
@cguedes cguedes merged commit 0e44eb5 into main Aug 22, 2023
8 of 11 checks passed
@cguedes cguedes deleted the sidebars-design branch August 22, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design for PrimarySideBar (plus PanelWrapper and PanelSection)
2 participants