Update design of welcome screen (including design bootstrap) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 84.10% 84.16% +0.06%
==========================================
Files 174 175 +1
Lines 9964 10016 +52
Branches 1097 1101 +4
==========================================
+ Hits 8380 8430 +50
- Misses 1573 1575 +2
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cguedes
approved these changes
Aug 21, 2023
| <WelcomeViewShortcut keys={['⌘', ',']} text="Show Settings" /> | ||
| <Logo /> | ||
| <div className="flex flex-row gap-20"> | ||
| <div className="flex w-[16.5rem] flex-col gap-10"> |
There was a problem hiding this comment.
nit: w-[16.5rem] - I don't like using arbitrary values for widths but I understand how that is need for this design.
sehyod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Welcome Screen to align with the new design. This also bootstraps the design work by creating useful CSS variables and installing Roboto font.
This also updates the desktop app's icon and the favicon for the web app.
Closes #369