Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get file ingestion running through http #395

Merged
merged 17 commits into from
Aug 24, 2023

Conversation

gjreda
Copy link
Collaborator

@gjreda gjreda commented Aug 22, 2023

fixes #366

This started as getting ingestion running through HTTP, but led to some new APIs so that we can move away from the sidecar CLI.

This PR adds the idea of a project_name to the projects core logic, removes some of the legacy /sidecar APIs and also adds the following:

References

  • List references => GET /api/references/{project_id}
  • Get a reference => GET /api/references/{project_id}/{reference_id}
  • Ingest references => POST /api/references/{project_id}
  • Update a reference => PUT /api/references/{project_id}/{reference_id}
  • Delete a reference => DELETE /api/references/{project_id}/{reference_id}
  • Bulk delete references => POST /api/references/{project_id}/bulk_delete

AI

  • Chat => POST /api/ai/{project_id}/chat

python/sidecar/http.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #395 (4c1469f) into main (7e79fa0) will decrease coverage by 0.24%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   82.98%   82.75%   -0.24%     
==========================================
  Files         184      184              
  Lines       10787    10840      +53     
  Branches     1144     1144              
==========================================
+ Hits         8952     8971      +19     
- Misses       1820     1854      +34     
  Partials       15       15              
Files Changed Coverage Δ
python/web.py 0.00% <0.00%> (-90.91%) ⬇️
python/sidecar/chat.py 89.06% <57.14%> (-4.28%) ⬇️
python/sidecar/storage.py 84.26% <77.27%> (-13.30%) ⬇️
python/sidecar/http.py 81.92% <78.78%> (-0.78%) ⬇️
python/sidecar/ingest.py 90.14% <100.00%> (+0.10%) ⬆️
python/sidecar/projects.py 96.66% <100.00%> (+0.05%) ⬆️
python/sidecar/shared.py 93.54% <100.00%> (+0.07%) ⬆️
python/sidecar/typing.py 97.57% <100.00%> (+0.01%) ⬆️
src/api/ingestion.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

python/sidecar/http.py Outdated Show resolved Hide resolved
@gjreda gjreda changed the title Get file ingestion running through http 🚧 Get file ingestion running through http Aug 22, 2023
@gjreda
Copy link
Collaborator Author

gjreda commented Aug 22, 2023

@cguedes This gets ingest working, but I'd appreciate your feedback on the other ingest related endpoints -- /ingest, /ingest_status, and /ingest_references. I feel like we should change those endpoints to accept a project_id, but I also don't want to break other desktop-related things for y'all on the client side.

@gjreda gjreda changed the title 🚧 Get file ingestion running through http 🚧 feat: Get file ingestion running through http Aug 22, 2023
@gjreda gjreda marked this pull request as ready for review August 24, 2023 19:36
@cguedes cguedes changed the title 🚧 feat: Get file ingestion running through http feat: Get file ingestion running through http Aug 24, 2023
@gjreda gjreda merged commit cd219c7 into main Aug 24, 2023
10 checks passed
@gjreda gjreda deleted the 366-get-file-ingestion-running-through-http branch August 24, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get file ingestion running through HTTP
3 participants