Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov config #398

Merged
merged 1 commit into from
Aug 23, 2023
Merged

chore: update codecov config #398

merged 1 commit into from
Aug 23, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Aug 23, 2023

Closes #397

default:
target: auto
threshold: 2% # allow for 2% reduction of coverage without failing
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to discuss this. I have noticed it's not rare for the coverage to decrease a bit during PRs, and we ignore it most of the time

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting is great IMO. Didn't knew they have such feature. I'm ok merging this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'm removing the draft status then
Ideally I wanted to set up a minimum target percentage, because with the config of this PR we could technically keep decreasing the coverage with several PRs until we reach low values. But I haven't found any option to do so

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #398 (762022e) into main (1c15395) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         178      178           
  Lines       10282    10282           
  Branches     1108     1108           
=======================================
  Hits         8560     8560           
  Misses       1708     1708           
  Partials       14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod marked this pull request as ready for review August 23, 2023 09:03
@cguedes cguedes merged commit e06f8cd into main Aug 23, 2023
10 checks passed
@cguedes cguedes deleted the update-codecov-config branch August 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codecov configuration
2 participants