Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve project details API #458

Conversation

gjreda
Copy link
Collaborator

@gjreda gjreda commented Aug 30, 2023

backend fixes #448

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #458 (d4e5a60) into main (43e1000) will increase coverage by 0.27%.
The diff coverage is 64.06%.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   79.94%   80.22%   +0.27%     
==========================================
  Files         195      195              
  Lines       11672    11660      -12     
  Branches     1115     1115              
==========================================
+ Hits         9331     9354      +23     
+ Misses       2325     2290      -35     
  Partials       16       16              
Files Changed Coverage Δ
src/api/projectsAPI.ts 32.80% <9.09%> (+4.22%) ⬆️
python/sidecar/http.py 81.71% <75.00%> (+0.15%) ⬆️
python/sidecar/projects.py 95.23% <91.30%> (-1.64%) ⬇️
python/sidecar/typing.py 98.00% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

python/sidecar/projects.py Outdated Show resolved Hide resolved
@gjreda
Copy link
Collaborator Author

gjreda commented Aug 31, 2023

@cguedes @sehyod I dropped the is_file and is_folder params y'all have on the TS side based on the convo in #448, but let me know if you'd like to keep them (see commit 776abd1)

@gjreda gjreda marked this pull request as ready for review August 31, 2023 18:23
danvk
danvk previously requested changes Aug 31, 2023
Copy link
Collaborator

@danvk danvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge in the latest changes on main so we could see how this looks in the new api-paths.ts file?

I had questions about how we want to handle nested directories and the test.

python/sidecar/projects.py Outdated Show resolved Hide resolved
python/sidecar/projects.py Outdated Show resolved Hide resolved
python/tests/test_projects.py Outdated Show resolved Hide resolved
python/tests/test_projects.py Show resolved Hide resolved
python/sidecar/http.py Outdated Show resolved Hide resolved
python/sidecar/http.py Show resolved Hide resolved
python/sidecar/http.py Outdated Show resolved Hide resolved
python/sidecar/http.py Outdated Show resolved Hide resolved
python/sidecar/http.py Outdated Show resolved Hide resolved
python/sidecar/projects.py Outdated Show resolved Hide resolved
python/sidecar/typing.py Outdated Show resolved Hide resolved
python/sidecar/typing.py Show resolved Hide resolved
python/sidecar/typing.py Outdated Show resolved Hide resolved
@cguedes cguedes self-requested a review September 1, 2023 17:48
@gjreda gjreda dismissed danvk’s stale review September 1, 2023 18:01

today's not a day Dan works on this project

@gjreda
Copy link
Collaborator Author

gjreda commented Sep 1, 2023

That dismissal sounds more curt than I intended. I also addressed @danvk's comments in my changes 😅

@gjreda gjreda merged commit b1c7433 into main Sep 1, 2023
10 checks passed
@gjreda gjreda deleted the 448-improve-projects-api-and-stop-depending-on-tauri-fs-types-backend branch September 1, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve projects API and stop depending on Tauri FS types
3 participants