Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove references regression #462

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Aug 31, 2023

This fixes #461

Also adds handler for Unhandled rejection in promise that displays in the notification tray

- use id instead of filename
- use the correct API method for the bulk delete
@cguedes cguedes linked an issue Aug 31, 2023 that may be closed by this pull request
@cguedes cguedes changed the title 461-remove-references-regression-after-425 fix Remove references regression Aug 31, 2023
@cguedes cguedes changed the title fix Remove references regression fix: remove references regression Aug 31, 2023
@cguedes cguedes requested a review from sehyod August 31, 2023 14:42
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #462 (f22adc5) into main (24e7cc9) will decrease coverage by 0.04%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   78.38%   78.35%   -0.04%     
==========================================
  Files         186      186              
  Lines       11155    11160       +5     
  Branches     1061     1061              
==========================================
  Hits         8744     8744              
- Misses       2396     2401       +5     
  Partials       15       15              
Files Changed Coverage Δ
src/application/App.tsx 0.00% <0.00%> (ø)
src/atoms/referencesState.ts 77.30% <0.00%> (ø)
src/api/ingestion.ts 95.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit 8089d47 into main Aug 31, 2023
10 checks passed
@cguedes cguedes deleted the 461-remove-references-regression-after-425 branch August 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references regression after #425
2 participants