Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the new active_project_id in the client code #478

Conversation

cguedes
Copy link
Collaborator

@cguedes cguedes commented Sep 4, 2023

This is part of #445

After this, we can implement the 3rd task of:

  • Remove the deprecated current_directory setting from the backend API

@cguedes cguedes linked an issue Sep 4, 2023 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #478 (ba68e4c) into main (e4c57e6) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   80.22%   80.22%   -0.01%     
==========================================
  Files         195      195              
  Lines       11661    11660       -1     
  Branches     1115     1115              
==========================================
- Hits         9355     9354       -1     
  Misses       2290     2290              
  Partials       16       16              
Files Changed Coverage Δ
src/application/listeners/projectEventListeners.ts 38.88% <0.00%> (-0.49%) ⬇️
src/AppStartup.tsx 90.62% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit 49729d7 into main Sep 4, 2023
10 checks passed
@cguedes cguedes deleted the 445-update-settings-to-adopt-project-id-instead-of-project-path branch September 4, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update settings to adopt project ID instead of project path
2 participants