-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new project dialog for web #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 80.76% 80.62% -0.15%
==========================================
Files 198 201 +3
Lines 11856 12025 +169
Branches 1141 1161 +20
==========================================
+ Hits 9576 9695 +119
- Misses 2266 2315 +49
- Partials 14 15 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sehyod
reviewed
Sep 5, 2023
sehyod
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #446
This PR introduces a new core atom for modals named
createModalAtoms
.With that, we can create a modal atoms for the create project model with:
And then open the modal using:
That would return a string with the modal return value (a string), or
null
if the modal was closed/canceled.The modal code would be something like: