Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PDF icon in tab #485

Merged
merged 3 commits into from
Sep 5, 2023
Merged

feat: add PDF icon in tab #485

merged 3 commits into from
Sep 5, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Sep 5, 2023

This adds a PDF icon for PDF Viewer editors

image

Closes #451

@sehyod sehyod requested a review from cguedes September 5, 2023 08:59
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #485 (3483a01) into main (49729d7) will increase coverage by 0.36%.
The diff coverage is 45.00%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   80.22%   80.58%   +0.36%     
==========================================
  Files         195      195              
  Lines       11660    11682      +22     
  Branches     1115     1119       +4     
==========================================
+ Hits         9354     9414      +60     
+ Misses       2290     2254      -36     
+ Partials       16       14       -2     
Files Changed Coverage Δ
src/application/views/WelcomeView.tsx 0.00% <0.00%> (ø)
src/components/icons.tsx 70.31% <ø> (+7.97%) ⬆️
src/application/components/icons.tsx 18.75% <23.07%> (+18.75%) ⬆️
src/application/components/OpenEditorsTabPane.tsx 100.00% <100.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cguedes cguedes merged commit 7792576 into main Sep 5, 2023
10 checks passed
@cguedes cguedes deleted the 451-add-pdf-icon branch September 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon for open PDF editors
2 participants