Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: activate venv instead of using poetry run #518

Merged
merged 8 commits into from
Sep 7, 2023
Merged

fix: activate venv instead of using poetry run #518

merged 8 commits into from
Sep 7, 2023

Conversation

sehyod
Copy link
Collaborator

@sehyod sehyod commented Sep 7, 2023

I think we had some issues with our cache and removing it fixed the failing CI.

To delete cache, you can go there. The one that had an issue here was venv-Linux-..., the cache for poetry dependencies. We are also caching yarn (node-cache-Linux-yarn-...) and now poetry with this PR (poetry-cache-...)

This PR is removing the unnecessary installation of pytest via pip (pytest is installed via poetry in setup-python)
This is also improving our CI by caching poetry so that python jobs now take half of the time they use to take:

Before the PR:
Screenshot 2023-09-07 at 15 30 31

After the PR:
Screenshot 2023-09-07 at 15 31 38

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #518 (fc9639b) into main (df40d2b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files         213      213           
  Lines       12098    12098           
  Branches     1179     1179           
=======================================
  Hits         9879     9879           
  Misses       2205     2205           
  Partials       14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sehyod sehyod requested a review from cguedes September 7, 2023 14:32
@sehyod sehyod marked this pull request as ready for review September 7, 2023 14:45
@cguedes cguedes merged commit e240d04 into main Sep 7, 2023
10 checks passed
@cguedes cguedes deleted the 517-fix-ci branch September 7, 2023 14:46
@sehyod sehyod mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants