-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Explorer panel design for multiple projects #532
feat: Explorer panel design for multiple projects #532
Conversation
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 81.81% 82.06% +0.24%
==========================================
Files 218 219 +1
Lines 12104 12242 +138
Branches 1197 1207 +10
==========================================
+ Hits 9903 10046 +143
+ Misses 2187 2182 -5
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
import { ArrowDownIcon, HorizontalDotsIcon } from './icons'; | ||
|
||
export function FileExplorer({ projectName }: { projectName: string }) { | ||
const [collapsed, setCollapsed] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stored in an atom for projects folders, so that when you close and re-open the explorer, everything keeps its state. I think it would be great to also save that in an atom for the projects.
I think we should create an atom openProjectState
with some useful values like name
, id
and isCollapsed
. When we update the app so support multiple projects, we can then update the atom to be a list of ProjectState
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your idea, but I think we should implement that later once we really support having multiple projects open at the same time. For now we are only making sure we have the design ready.
As part of this change can we create a top-level folder called "documents", put it above exports and uploads, and put the documents under there? |
Or if that breaks the data model, we should at least have the documents above the exports and uploads, I think. |
That change of having a top-level But showing the files before folders (i.e. above exports and uploads) should be very simple. We will do that in a follow-up PR. CC @sehyod |
I created the issue: #536 |
This PR updated the UI to the latest design with menu triggers for the project and files.