bug: Update binary build script to first remove existing binary (#70) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjreda
changed the title
gjreda
changed the title
cguedes
approved these changes
Jun 1, 2023
gjreda
deleted the
70-update-yarn-python-to-remove-binary-before-creating-new-one
branch
sergioramos
pushed a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to rebuild the binary while some of these files are still around results in the new binary being created from older specs.
Running
yarn pythonshould take ~2 minutes to complete.After running this script, there should be a single
mainfile atsrc-tauri/bin/python/main-aarch64-apple-darwin/(the last directory name will be slightly different if you are not on a Mac).