Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter is not working if ximgdiff is disabled #28

Closed
stevschmid opened this issue Mar 9, 2020 · 1 comment · Fixed by #58
Closed

Filter is not working if ximgdiff is disabled #28

stevschmid opened this issue Mar 9, 2020 · 1 comment · Fixed by #58
Labels
bug Something isn't working

Comments

@stevschmid
Copy link

Describe the bug

If ximgdiff is disabled in regconfig.json, filtering in the generated HTML report is not working.

Reproduced step

Check out reg-cli-report-ui, disable ximgdiffConfig in develop/index.html

ximgdiffConfig: { enabled: false, workerUrl: './worker.js' },

Start the dev env via yarn start. Filtering is not working.

Cause

if (!enabled || !workerUrl) {
return;
}

this._worker is only created if ximg diff is enabled. Since this._worker is used to relay the filtering messages, the filtering is not working if XIMGDiffConfig.enabled = false

Expected behavior

Filtering is working even with ximgdiff disabled.

Actual behavior

Filtering is not working with ximgdiff disabled.

@stevschmid stevschmid added the bug Something isn't working label Mar 9, 2020
@stefanteixeira
Copy link

I'm using Loki for visual regression testing, but I'm using reg-cli for reporting, as some other Loki users are doing (found about reg-cli in this issue oblador/loki#76).

I'm experiencing the same issue with filtering, it would be helpful to have it working or at least have a workaround. Could someone please check on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants