Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency mustache to v4 #338

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2020

This PR contains the following updates:

Package Type Update Change
mustache dependencies major 3.2.1 -> 4.0.1

Release Notes

janl/mustache.js

v4.0.1

Compare Source

Fixed
  • [#​739]: Fix custom delimiters in nested partials, by [@​aielo].

v4.0.0

Compare Source

Majority of using projects don't have to worry by this being a new major version.

TLDR; if your project manipulates Writer.prototype.parse | Writer.cache directly or uses .to_html(), you probably have to change that code.

This release allows the internal template cache to be customised, either by disabling it completely
or provide a custom strategy deciding how the cache should behave when mustache.js parses templates.

const mustache = require('mustache');

// disable caching
Mustache.templateCache = undefined;

// or use a built-in Map in modern environments
Mustache.templateCache = new Map();

Projects that wanted to customise the caching behaviour in earlier versions of mustache.js were forced to
override internal method responsible for parsing templates; Writer.prototype.parse. In short, that was unfortunate
because there is more than caching happening in that method.

We've improved that now by introducing a first class API that only affects template caching.

The default template cache behaves as before and is still compatible with older JavaScript environments.
For those who wants to provide a custom more sopisiticated caching strategy, one can do that with an object that adheres to the following requirements:

{
  set(cacheKey: string, value: string): void
  get(cacheKey: string): string | undefined
  clear(): void
}
Added
  • [#​731]: Allow template caching to be customised, by [@​AndrewLeedham].
Removed
  • [#​735]: Remove .to_html(), by [@​phillipj].

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@reg-suit
Copy link

reg-suit bot commented Oct 22, 2020

reg-suit detected visual differences.

Check this report, and review them.

🔴

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@bokuweb bokuweb merged commit b6239c7 into master Oct 27, 2020
@bokuweb bokuweb deleted the renovate/mustache-4.x branch October 27, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants