Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular support #21

Merged
merged 5 commits into from
Jan 3, 2018
Merged

Angular support #21

merged 5 commits into from
Jan 3, 2018

Conversation

Quramy
Copy link
Member

@Quramy Quramy commented Jan 3, 2018

Hi. Storybook Angular app has released, so I've applied Angular support to this addon.

What I did

  • Add 2 functions for Angular projects, angular/init-screenshot and angular/with-screenshot.
  • Detect and switch React/Angular in init-screenshot and with-screenshot func.
  • Add Angular CLI based sample project

Almost all files under examples/angular-cli are generated ng new cmd. The following files were touched or created by me:

  • src/app/my-button/*
  • src/app/button-group/*
  • stories/*
  • .storybook/*
  • package.json (storybook and screenshot scripts)

How to test

You can test via the following steps:

cd examples/angular-cli
yarn install --pure-lockfile
yarn screenshot

If successful running, __screenshot__ which includes 3 PNG files is created under the example/angular-cli dir.

@wadackel wadackel self-requested a review January 3, 2018 09:14
Copy link
Collaborator

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😆
It seems to be working perfectly!

@wadackel wadackel merged commit 2013b63 into reg-viz:master Jan 3, 2018
@wadackel
Copy link
Collaborator

wadackel commented Jan 3, 2018

Hi @Quramy Thank you for Contribute!!
Released as v0.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants